Base information

Symptom (bug) / Objective (enhancement)

When a dictionary entry expects more arguments than they are passed in the code calling it (often a poor translation/mistake in the ITSM Designer), we get a ValueError crashing the application:

Uncaught ValueError: The arguments array must contain 2 items, 1 given in /core/valuesetdef.class.inc.php:438

Cause (bug)

This is expected as vsprintf since PHP 8.0 throws a ValueError if the number of arguments doesn't meet its needs.

Proposed solution (bug and enhancement)

This pull request add a wrapper in utils (as we did with EscapeHTML and HTMLEntities) in order to prevent a crash by creating placeholders as arguments and throwing a silent error.

If we have the following entry:

This object name is %1$s and its id is %2$s

But the code only provides as arguments [ 'Object name'], the generated string will be

This object name is Object name and its id is %2$s and we'll have an error in the logs

Checklist before requesting a review

• I have performed a self-review of my code
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• Is the PR clear and detailed enough so anyone can understand digging in the code?