Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jtippet/IcoTools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: DHowett/IcoTools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 12 files changed
  • 1 contributor

Commits on Sep 19, 2022

  1. Update IcoTools to .NET 6 

    This required one major change and a couple resultant minor changes.

1. ImageSharp 2+ is required for .NET 6 support; 2.x is
   license-compatible with 1.x, and it doesn't seem to have caused any
   significant compatibility issues.
2. ImageSharp 2 moved PNG compression "levels" from numeric values to
   enumerated values.
3. There is a new ByteOrder type in ImageSharp 2.x that conflicts with
   Ico.Binary.ByteOrder. Instead of moving everything to the ImageSharp
   ByteOrder constants, I namespaced the few conflicting uses.
4. Many ImageSharp operations grew support for cancellation tokens. I
   chose to use the "None" CancellationToken instead of propagating
   cancellation across the surface of IcoLib.

An alternate means of addressing point three would be to resolve the
conflicts in favor of ImageSharp's ByteOrder type. I believe that this
would be much more invasive for minimal gain.
    @DHowett
    DHowett committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    51990d0 View commit details
    Browse the repository at this point in the history
Loading