-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
Description
From https://github.com/DQM4HEP/dqm4hep-core/issues/74, @tcoates3 :
The PropertyWithinExpectedTest contains a lot of different processes and the required parameters vary based on other parameters. This makes documentation difficult, and it may be confusing for users not familiar with the code.
I suggest simplifying this qtest by splitting it into three:
- PropertyWithinRangeTest – Obtains the property (mean, mean90, rms, rms90, median) and checks whether it is between two numbers. The user must give Property, as well as RangeLower and RangeUpper. The test will return the p-value.
- PropertyAboveThresholdTest – Obtains the property as above, and checks whether it is higher than a given number. The user must give Property as well as Threshold. The test will return 1 if the number is above the threshold, 0 otherwise.
- PropertyBelowThresholdTest – Obtains the property as above, and checks whether it is lower than a given number. The user must give Property as well as Threshold. The test will return 1 if the number is below the threshold, 0 otherwise.
The parameter and test names I've used are just demonstrations, they can obviously be renamed to fit with other qtests if needed.