Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dependency check #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix dependency check #386

merged 1 commit into from
Mar 12, 2024

Conversation

@nsavoire
Copy link
Collaborator

What does this PR do?

  • Make sure script fails when dependency file is missing
  • Alpine ddprof should not have any dependency

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2024 •
edited
Loading

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+f1f31121.29880977 ddprof 0.17.0+ef0bd8ce.29942416

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2024 •
edited
Loading

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.0+f1f31121.29880977 ddprof 0.17.0+ef0bd8ce.29942416

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@nsavoire
Fix dependency check
ef0bd8c 
* Make sure script fails when dependency file is missing
* Alpine ddprof should not have any dependency
@nsavoire nsavoire force-pushed the nsavoire/fix_dependency_check branch from 156ccda to ef0bd8c Compare March 12, 2024 08:52
r1viollet
r1viollet approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for improving the testing and covering new alpine versions

@nsavoire nsavoire merged commit be63dd5 into main Mar 12, 2024
@nsavoire nsavoire deleted the nsavoire/fix_dependency_check branch March 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r1viollet r1viollet r1viollet approved these changes

@sanchda sanchda Awaiting requested review from sanchda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsavoire @r1viollet