fix readCertificateInfo for the case when cert subject is empty #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/pem.js # test/pem.js
…l/pem # Conflicts: # README.md # lib/pem.js # package.json # test/pem.js
…l/pem # Conflicts: # README.md # lib/pem.js # package.json # test/pem.js
|
@Dexus Can you please check why did the build fail? |
|
@TatyanaBol it fails because of CI different NPM. |
|
@Dexus Can you please fix it. See: https://travis-ci.community/t/npm-ci-will-fail-if-cached-dependency-includes-npm/4203 |
Dexus
pushed a commit
that referenced
this pull request
Sep 17, 2019
Dexus
pushed a commit
that referenced
this pull request
Sep 17, 2019
## [1.14.3](v1.14.2...v1.14.3) (2019-09-17) ### Bug Fixes * **package:** fix [#264](#264) & remove package-lock.josn ([53f1356](53f1356))
|
🎉 This PR is included in version 1.14.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you for your quick response!
Tatyana Bolshinsky | Senior Program Developer
IBM Cloud Security Tel +972-9-952-5683
From: "Josef Fröhle" <[email protected]>
To: Dexus/pem <[email protected]>
Cc: Tatyana <[email protected]>, Mention
<[email protected]>
Date: 17/09/2019 11:00
Subject: [EXTERNAL] Re: [Dexus/pem] fix readCertificateInfo for the
case when cert subject is empty (#264)
? This PR is included in version 1.14.3 ?
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot ??
?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue #263