Tags: Etherial-Z/idb
Tags
Remove deprecated fields in idb proto Summary: These are no longer used and have long since been removed. This will allow us to re-use slots, or at the very least ignore them from now on Reviewed By: c-ryan747 Differential Revision: D21640268 fbshipit-source-id: 47e30a09c93695e65916d416e21d673c493f2e15
fix spawning notifier Summary: list targets was not spawning a notifier as it's new implementation was not calling get_stub(). this is a problem if list-targets is called before any other command. but since list-targets is normally the first command to be called i added another call there. i have also added clearing the local_targets_file on `idb kill` as a cleanup Reviewed By: zbigniew-malinowski Differential Revision: D16985438 fbshipit-source-id: 933dc9f2a35fa7a50a473c87959658a6075cbe46
add ability to custom Instruments timings for apps Summary: We can now customize the timings for the Instruments operation. For Wilde, we need a slighly larger timeout for the `Instruments Trace Completed` message to show up in a faulure case. For example, in this Wilde [test](https://our.intern.facebook.com/intern/chronos/jobinstance/?jobinstanceid=5515701566&smc=chronos_gp_admin_client), Instruments did not start properly, but IDB thought it was launched properly. This resulted in the QPL marker missing error. Differential Revision: D16567429 fbshipit-source-id: d0c0a5905f61ad7c959034010d415c037de86d81
Don't fail forwardInvocation if mediator is nil'd Summary: If the mediator has died then we don't want to fail on a `forwardInvocation:`, this will nil-message-send, which would be the behaviour if there was no forwarding involved Reviewed By: zeyadsalloum Differential Revision: D15133659 fbshipit-source-id: b2580a4b12751a96ee187b3b69ab7a1000e69dbf