Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@white-gorilla
Copy link
Contributor

@white-gorilla white-gorilla commented Oct 19, 2022

This PR adds the static documentation site, customized with a landing page.
On this landing page, the Highlights section (benchmarks + schema) is missing.

Note: For the moment, I have left some things as comments in the configuration file.

Reminder

  • The two commands to launch the preview and the generation are in the file docs/readme.md.
  • Don't forget to review the Github Action part.

Tested browsers

  • brave: v1.45.113 chromium 107.0.5304.62
  • Safari desktop: 16.1 (17614.2.9.1.13, 17614)
  • Firefox desktop: 107.0b5 (64 bits)
  • Firefox mobile: 106.0 (20303). iPad Pro / iPhone 13
  • Safari mobile: iOS 16.1. iPad Pro / iPhone 13

fix #113

@white-gorilla white-gorilla marked this pull request as draft October 19, 2022 14:12
@white-gorilla white-gorilla self-assigned this Oct 19, 2022
@github-actions github-actions bot added feature and removed feature labels Oct 19, 2022
@white-gorilla white-gorilla temporarily deployed to github-pages October 19, 2022 15:56 Inactive
@white-gorilla white-gorilla marked this pull request as ready for review November 2, 2022 14:47
Copy link
Contributor

@gaetansnl gaetansnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, congrats 🎉 The only thing I'm not sure is the workflow, never used github pages

The important comment is about the code example, we changed things yesterday

docs/README.md Outdated
The easiest and least intrusive way is to use docker.

```shell
# Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not useful, image will be pulled anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: I deleted the unnecessary line.

</div>
</section>
<section class="knl-snippet md-grid">
<pre><code class="knl-snippet__code"><span class="instruction">from</span> transformers <span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we changed the way it works, need to change the example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: the snippet is iso with the readme file of kernl.

@@ -0,0 +1,188 @@
{% extends "main.html" %}
Copy link
Contributor

@gaetansnl gaetansnl Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right. It's much less readable and accessible. But visually it becomes different.
I would rather readjust and have it validated by a feedback from the team. I note it and make an issue in this sense.

{% extends "main.html" %}
{% block tabs %}
{{ super() }}
<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is isn't in css ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the context of Material for MkDocs. For styles to be applied, they must be at the bottom of the cascading.

- name: Upload artifact
uses: actions/upload-pages-artifact@v1
with:
# Upload entire repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entire repository ? what to you mean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: upload entire static site

name: github-pages
url: ${{ steps.deployment.outputs.page_url}}
runs-on: ubuntu-latest
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reference to /docs here ? @white-gorilla

@white-gorilla white-gorilla temporarily deployed to github-pages November 3, 2022 15:10 Inactive
@white-gorilla white-gorilla merged commit 7383112 into main Nov 3, 2022
@white-gorilla white-gorilla deleted the feat/add-static-documentation-website branch November 3, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

[LLM][FRONT] Implement the design of the chosen mockup to deploy the site.

3 participants