-
Notifications
You must be signed in to change notification settings - Fork 97
docs: add static documentation website #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, congrats 🎉 The only thing I'm not sure is the workflow, never used github pages
The important comment is about the code example, we changed things yesterday
docs/README.md
Outdated
| The easiest and least intrusive way is to use docker. | ||
|
|
||
| ```shell | ||
| # Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not useful, image will be pulled anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: I deleted the unnecessary line.
| </div> | ||
| </section> | ||
| <section class="knl-snippet md-grid"> | ||
| <pre><code class="knl-snippet__code"><span class="instruction">from</span> transformers <span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we changed the way it works, need to change the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: the snippet is iso with the readme file of kernl.
| @@ -0,0 +1,188 @@ | |||
| {% extends "main.html" %} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right. It's much less readable and accessible. But visually it becomes different.
I would rather readjust and have it validated by a feedback from the team. I note it and make an issue in this sense.
| {% extends "main.html" %} | ||
| {% block tabs %} | ||
| {{ super() }} | ||
| <style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is isn't in css ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to the context of Material for MkDocs. For styles to be applied, they must be at the bottom of the cascading.
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v1 | ||
| with: | ||
| # Upload entire repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
entire repository ? what to you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: upload entire static site
| name: github-pages | ||
| url: ${{ steps.deployment.outputs.page_url}} | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reference to /docs here ? @white-gorilla
This PR adds the static documentation site, customized with a landing page.
On this landing page, the Highlights section (benchmarks + schema) is missing.
Note: For the moment, I have left some things as comments in the configuration file.Reminder
docs/readme.md.Tested browsers
fix #113