Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nsoblath
Copy link
Collaborator

@nsoblath nsoblath commented Apr 29, 2022

Updates

  • Updated Windows build to Windows 2022; Visual Studio updated to v17, 2022
  • Specified Ubuntu build (20.04) and Mac build (11)
  • Fixed CMake syntax error around Python detection
  • Statically link Python in the Mac and Ubuntu builds
  • Build arpack manually in the Mac build to get the static library
  • Updated FETK to v1.9.3
  • Updated installation documentation
  • Added a CentOS Dockerfile; updated the Ubuntu Dockerfile

Procedure

  1. Change Version Number

    • Edit VERSION
      Increment the value after the comment block, which is in the form
      M_m_u
      Where:
      • M is the Major version - increment if there are breaking changes or dropping support for previous features
      • m is the Minor version - increment for new features added
      • u is the Micro version - increment for adding small changes like new tests or fixing small bugs
  2. Update the Releases document

    • Edit docs/releases.rst
      • Document major/minor changes for this release
  3. Update License info

    • Update license date in LICENSE.md
    • Update license dates and information in source files
      • In apbs/src edit all .c source files and all .h header files, update dates
  4. Create a Pull Request (PR)

    • Create a new Pull Request
      • Base branch should be release
      • Source branch should be main
      • Briefly describe the changes included
  5. Check tests

    • Go to the Actions tab in GitHub
    • Tests are performed for three target platforms:
      • Ubuntu
      • MacOSX
      • Windows
    • Ensure that the builds and associated tests were successful
    • Ensure that the use tests were successful
    • Ensure that the build artifacts were uploaded to the action
  6. Merge the PR

    • Ensure that the Release is correctly created
    • Ensure that the builds and associated tests were successful
    • Ensure that the use tests were successful
    • Ensure that the build artifacts were uploaded to the Release
  7. Update http://www.poissonboltzmann.org/apbs/release-history with new release information.

  8. Pat yourself on the back for a job well done!

nsoblath and others added 9 commits February 14, 2022 13:45
* Fixed syntax errors in checking for max python version

* Switch OS specification to absolute versions and reduce places where those are specified

* Update Windows config to Visual Studio 17 2022

* skip ci -- Updated releases.rst with update info

* [skip ci] Added release note

Co-authored-by: Noah Oblath <[email protected]>
* Switch OS specification to absolute versions and reduce places where those are specified

* Update Windows config to Visual Studio 17 2022

* skip ci -- Updated releases.rst with update info

Co-authored-by: Noah Oblath <[email protected]>
Co-authored-by: Darren Curtis <[email protected]>
* Turn off debugging steps

* Only install python in Windows for "Test Usage" job, as we'll be statically linking Python in Mac and Linux.

* Search for static python libs in linux and mac when doing a static build

* Turn on tmate to check library linking

* Find threads explicitly

* Tmate only on failure

* Verbose build for debugging

* Added two more missing libraries: libdl and libutil

* Enable tmate for the mac use-test job

* Test with Python 3.10

* Test with Python 3.10 revealed we needed libintl.  So that's added now.  Should be mac-specific

* Can't include_directories() on an empty variable

* Typo fix

* Find Iconv

* Add linking of APBS to CoreFoundation framework under macOS

* Remove debugging

* Removing some of the debugging tools used in testing the build.

* Switch back to the standard build with Python 3.9

* Removed last tmate debugging

* [skip ci] Document changes

Co-authored-by: Noah Oblath <[email protected]>
* First committed version of Dockerfile.centos

* Add alt config workflow

* Alt config build: test docker builds

* In Dockerfile, specify APBS_STATIC_BUILD instead of BUILD_SHARED_LIBS

* Missing backslash found

* Fixing bugs in both Dockerfiles

* Dockerfile bug fixing

* Complete missing pieces of ensuring a position-independent-code build

* Minor fixes

* Switch to a shared-library build in the Ubuntu Docker build

* Rename Dockerfile --> Dockerfile.ubuntu

* Override APBS_STATIC_BUILD when needed

Co-authored-by: Noah Oblath <[email protected]>
* Address missing linkages

* Cleanup FETK import

* Multithreaded build in docker now controlled by a build argument

* Install superlu as a dependency in the Ubuntu docker build

* Update the FETK version in use by the automatic builds (still on a development branch)

* Add in debugging tmate session for mac

* Manually build arpack to get the static lib (which seems to have disappeared?)

* Remove -j flags

* Set fortran compiler for arpack build

* Engaging brain, fixing mac-build commands

* Comment out tmate session

* Update the FETK commit to be the main branch, pre-release

* Update the changelog

* Updated default FETK build to commit v1.9.3 (57195e)

Co-authored-by: Noah Oblath <[email protected]>
* Fix python test max-version test in apbs/CMakeLists.txt

* Turn on the alternate non-docker builds, with updates from the main build

* Fixing the python max version test in apbs/tests/CMakeLists.txt

* Fixing the python max version test in apbs/tools/python/CMakeLists.txt

* Test commit: remove python-max-version definition

* Simplify the Python search by looking for an exact version

* Add a default PYTHON_VERSION

* Adapt the various files involved in building APBS to the new Python version setup

* Didn't setup the python version correctly in the GHA builds

Co-authored-by: Noah Oblath <[email protected]>
@nsoblath nsoblath requested a review from intendo April 29, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants