feat: add claim using auth #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib.rs # src/models.rs
xgreenx
reviewed
Mar 16, 2024
MujkicA
reviewed
Mar 28, 2024
| fuel_faucet_max_dispenses_per_minute=20 | ||
| fuel_faucet_min_gas_price=0 | ||
| fuel_faucet_dispense_amount=10000 | ||
| fuel_faucet_clerk_pub_key="6Ld3cEwfAAAAAMd4QTs7aO85LyKGdgj0bFsdBfre" |
There was a problem hiding this comment.
What values should be used here?
MujkicA
reviewed
Mar 28, 2024
|
I've fixed the tests and made some light adjustments. Shoutout to @nedsalk for helping me pinpoint some errors related to frontend/backend cookie handling. |
…/claim-auth # Conflicts: # src/lib.rs # src/models.rs
xgreenx
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Look good to me! I only have several questions for @luizstacio I will ask them in Slack
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| struct MockAuthHandler { |
There was a problem hiding this comment.
Very nice way to bypass registration in the tests!=)
xgreenx
approved these changes
Apr 8, 2024
xgreenx
added a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes social login for claiming faucet tokens using clerk as a provider.
Also includes code splitting.