Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Recom settings for different configurations require preprocessing switch at compile time #744

@JanStreffing

Description

@JanStreffing

Currently, RECOM is programmed in such a way that switching between different configs e.g. (https://github.com/FESOM/fesom2/tree/main/config/bin_2p1z1d vs https://github.com/FESOM/fesom2/tree/main/config/bin_2p3z2d) requires a preprocessing flag to read from the subfolders. This is not a good way of doing things. Ideally we do our runs with the namelists from the main config folder, which are kept up to date and tested with github CI tests.

I would suggest we keep only one namelist.recom, and we enter the current selection of proprocessing flags as switches to be selected there. Then we only need that one file

This block shall not be edited by model uses locally, and in fact can be removed, once the recom settings can be selected from namelist.recom.

fesom2/src/CMakeLists.txt

Lines 249 to 251 in 9240b3f

if(${RECOM_COUPLED})
target_compile_definitions(${PROJECT_NAME} PRIVATE __recom USE_PRECISION=2 __3Zoo2Det __coccos)# __usetp)
endif()

And additional advantage is, that you don't need to recompile, to select the recom config.

@chrisdane @suvarchal @patrickscholz @JudithHauck

Metadata

Metadata

Labels

enhancementNew feature or request

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions