Add support for cross experiment variable references #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in workspace info where variables that contained the @ symbol would throw and error due to color.cprint expecting a color identifer. Additionally, the method is restructure to prepare for cross experiment referneces. To aid this, all experiments are generated in the first pass, and second (just to make printing nicer) the experiments are generated again but only to scope variables properly.
38737f9 to
785c559
Compare
rfbgo
previously approved these changes
Mar 1, 2023
This commit updates the AST evaluation logic to be easier to follow. Additionally, it splits handling of the node types out into separate helper methods to allow them to be extended more easily in the future.
This commit adds logic into the AST evaluation code to extract a cross
experiment variable reference.
This currently takes the form of:
`var_name: other_var in experiment_namespace`
Where:
`var_name` is the name of the experiment local variable
`other_var` is the name of the remote experiment variable
`experiment_namespace` is a fully qualified experiment namespace
of the form
'application_name'.'workload_name','experiment_name'
Also, add tests for this feature
2c1b726 to
9614810
Compare
rfbgo
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge performs three tasks:
ramble workspace infocommand, in preparation for cross experiment variable reference expansionCross experiment variable references allow an experiment to refer to a variable definition in a different experiment.
This takes the form of:
In the above example,
other_varin test2 would have a value of'my_value'.