Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SimonMarquis
Copy link
Contributor

@SimonMarquis SimonMarquis commented Jul 6, 2025

mostly based on CentralPortalOptions docs.

Closes #132

mostly based on `CentralPortalOptions` docs.
@SimonMarquis SimonMarquis marked this pull request as ready for review July 6, 2025 10:13
@martinbonnin
Copy link
Member

Thanks for opening this! Any thought about "just" putting a big code block with all the CentralPortalOptions possible values?

All options

nmcpAggregation {
  centralPortal {
    // publish manually from the portal
    publishingType = "USER_MANAGED"

    // Increase the validation timeout to 30 minutes
    validationTimeout = Duration.of(30, ChronoUnit.MINUTES)
    // Disable waiting for validation
    validationTimeout = java.time.Duration.ZERO

    // Publish automatically once validation is successful
    publishingType = "AUTOMATIC"

    // Increase the publishing timeout to 30 minutes
    publishingTimeout = Duration.of(30, ChronoUnit.MINUTES)
    // Disable waiting for publishing
    publishingTimeout = java.time.Duration.ZERO

    // Customize the publication name 
    publicationName = "My Awesome Library version $version"
  }
}

I find out my brain is used to reading code blocks and comments more than regular paragraphs. It's definitely in the realm of personal preference though so no strong opinion either way

@SimonMarquis
Copy link
Contributor Author

That would be great as well. Should I still keep the nmcpZipAggregation appart?

@SimonMarquis SimonMarquis changed the title Document "advanced usages" in README.md Document all options in README.md Jul 6, 2025
@martinbonnin
Copy link
Member

Should I still keep the nmcpZipAggregation appart?

That'd be great, that is something different.

@SimonMarquis
Copy link
Contributor Author

Let me know if the current version, with these titles and heading is OK for you.

@martinbonnin
Copy link
Member

Looks great to me, thanks!

@martinbonnin martinbonnin merged commit d567c6f into GradleUp:main Jul 6, 2025
@SimonMarquis SimonMarquis deleted the docs-advanced-usage branch July 6, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic publishing without timeout

2 participants