Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cartesian: K-offset writes bound check is failing #1754

@FlorianDeconinck

Description

@FlorianDeconinck

Consider the test column_physics_conditional in tests/cartesian_tests/integration_tests/multi_feature_tests/test_code_generation.py. A fix in https://github.com/GridTools/gt4py/pull/1791 moved the interval to interval(1,-1) in line with the access and the domain defined.

But a previous version had the interval at inteval(1,None) which leads to a race condition and an OOB.

The stencil mix variable offset in K, where OOB can't be detected (see #1684), and scalar offset which should be detected.

  • Reproduce with a smaller, simpler example
  • Enforce bounds or error out

Original ticket:

See failure on gt:gpu here; https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4455690602105886/4525297225819146/-/jobs/8381258008

Translate tests is test_K_offset_write_conditional and should be modified when true fix comes into place.

Temporary fix to deactivate the feature: #1755

Metadata

Metadata

Assignees

No one assigned

    Labels

    gt4py.cartesianIssues concerning the current version with support only for cartesian grids.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions