Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release of Spoon 10.2.0 #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

release of Spoon 10.2.0 #4946

merged 1 commit into from
Oct 21, 2022

Conversation

@monperrus
Copy link
Collaborator

@monperrus monperrus commented Oct 6, 2022 •
edited
Loading

New features

Bug fixes

Performance

Governance

Authors

Name Nb Commit
renovate[bot] 81
I-Al-Istannen 33
Hannes Greule 21
MartinWitt 21
Simon Larsén 9
Martin Monperrus 9
Mikael Forsberg 4
Aman Sharma 3
Guillaume Toison 3
arsenkhy 1
chammp 1
César Soto Valero 1
Arvid Siberov 1

slarse
slarse approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we go ahead and make the release?

@monperrus
Copy link
Collaborator Author

monperrus commented Oct 7, 2022 via email

@MartinWitt
Copy link
Collaborator

MartinWitt commented Oct 21, 2022

As I really dont know how we create releases feel free to merge it @monperrus if everything is ready.

@monperrus monperrus merged commit f57b3c0 into master Oct 21, 2022
@monperrus monperrus deleted the monperrus-patch-2 branch October 21, 2022 17:01
@monperrus
Copy link
Collaborator Author

monperrus commented Oct 21, 2022 •
edited
Loading

Here is what I've done:

  • Checkout commit to be released:
    • git checkout -b <version> <commit>
    • eg git checkout -b 10.2.0 ee73f4376aa929d8dce950202fabb8992a77c9fb
  • Modify the pom.xml
    • sed -i -e 's/<version>-SNAPSHOT/<version>/' pom.xml
    • eg sed -i -e 's/10.2.0-SNAPSHOT/10.2.0/' pom.xml
  • Create release on Maven Central with mvn deploy (using profile release, see below)
    • JAVA_HOME=/usr/lib/jvm/java-1.11.0-openjdk-amd64/ mvn clean deploy -Prelease -DskipTests -Dgpg. -Dgpg.keyname=074F73B36D8DD649B132BAC18035014A2B7BFA92
  • Create release on Github
    • git tag spoon-core-<version>
    • eg git tag spoon-core-10.2.0
    • git push inria spoon-core-<version>
    • eg git push inria spoon-core-10.2.0

@SirYwell
Copy link
Collaborator

SirYwell commented Oct 21, 2022

Should the description of this PR be updated? It currently does not contain the PRs that where merged after the PR was opened.

@monperrus
Copy link
Collaborator Author

monperrus commented Oct 21, 2022

You're right @SirYwell, thanks. Fixed with 3 additional bug fixes.

Next time, we'll try to minimize the time between opening and merging of the release PR!

@SirYwell
Copy link
Collaborator

SirYwell commented Oct 21, 2022

Next time, we'll try to minimize the time between opening and merging of the release PR!

I agree, maybe we can even "freeze" the master branch during that time.

@algomaster99 algomaster99 mentioned this pull request Nov 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinWitt MartinWitt MartinWitt approved these changes

+1 more reviewer

@slarse slarse slarse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@monperrus @MartinWitt @SirYwell @slarse