Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleaning up launch files #36

@kaarmu

Description

@kaarmu

It is time to do some spring-cleaning of the launch files again.

To resolve this issue, I would like to see two PRs for svea_sensors and svea_core. Currently, there are many outdated and redundant launch files in svea_sensors. It would be good to streamline the things we are using and removing the things we are not using. Furthermore, to improve user experience it would be nice to have a main launch file in svea_core, much like what localize.launch is for svea_sensors. This launch file, maybe we can call it svea.launch, should call localize.launch, foxglove_bridge.launch, serial_node and more. IMO, the aim should be that for a typical experiment/demo there is only this:

<?xml version="1.0"?>
<launch>
    <!-- My Very Cool Experiment That Is Using AI, ML, Big Data, IoT, ... -->
    
    <include file="$(find svea_core)/launch/svea.launch">
        <!-- svea.launch arguments... -->
    </include>
    
    <node name="cool_node" pkg="awesome_project" type="cool_node.py">
        <!-- experiment parameters... -->
    </node>

</launch>

After the discussions we have had, I suggest that:

  • for svea_sensors PR, @Annika-wyt looks into said improvements
  • for svea_core PR, @sulthansf creates our first svea.launch

We should also think about abstraction levels, e.g. where things like map_server should be called (svea.launch or localize.launch?).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions