fix(DataMapper): Avoid attaching JSON schema to the source body #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
+ Coverage 81.91% 81.93% +0.01%
==========================================
Files 471 471
Lines 15008 15020 +12
Branches 3313 3318 +5
==========================================
+ Hits 12294 12306 +12
- Misses 2546 2712 +166
+ Partials 168 2 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where JSON schemas could be incorrectly attached to source body documents in the DataMapper, which is not supported. The fix adds file extension validation and user feedback for unsupported file types.
- Validates file extensions before allowing schema attachment based on document type
- Shows appropriate error messages when JSON schemas are attempted on source body
- Disables the attach button when no valid files are selected
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AttachSchemaButton.tsx | Adds file extension validation and error handling to prevent JSON schema attachment to source body |
| AttachSchemaButton.test.tsx | Adds comprehensive test coverage for new validation scenarios and error cases |
packages/ui/src/components/Document/actions/AttachSchemaButton.tsx
Outdated
Show resolved
Hide resolved
|
lordrip
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2429
Following up #2427 (comment)
2025-08-07.12-00-54.mp4