fix Transaction.getChainId when v=27 must return null #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Novais <[email protected]>
8774b65 to
22dd273
Compare
NickSneo
approved these changes
Jan 10, 2025
Member
NickSneo
left a comment
There was a problem hiding this comment.
LGTM, thanks for pointing out
Contributor
Author
|
@NickSneo thanks for merging it. When do you think it will be released? |
Member
|
Hey @jpnovais , we will make a release by this month end. Currently we are fixing web3j-android release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix
deriveChainId(long v), whenv=27orv=28must return null instead of0, as per EIP155Where should the reviewer start?
crypto/src/main/java/org/web3j/crypto/TransactionUtils.java#deriveChainId
Why is it needed?
The current seems to be buggy and comply with the EIP155 spec
Checklist