unit output cleanup #265
Merged
unit output cleanup #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or unit string conversions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 4571 4579 +8
=========================================
+ Hits 4571 4579 +8 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
Author
|
Going to merge this and fix the clang tidy stuff later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit cleanup based on #264.
specifically use Hz when a s^-1 is only there.
split the unit name maps into si and non-si versions.
fix value for "quad" and some further refinement of "btu" related units.