Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor and improve Tap Tempo #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Refactor and improve Tap Tempo #8098

wants to merge 28 commits into from
+107 −87

Conversation

@sakertooth
Copy link
Contributor

@sakertooth sakertooth commented Oct 18, 2025 •
edited
Loading

This PR improves the Tap Tempo tool, refactoring its code and providing a more robust BPM calculation algorithm.

Changes

  • Refactoring the code to improve maintainability and code cleanliness (renaming functions, moving functionality outside of GUI code, removing friend access to TapTempoView, etc)
  • Improvements to the BPM algorithm
    1. Apply an EMA (exponential moving average, also known as exponential smoothing) filter to the BPM calculation. This helps minimize small rapid changes (jitter) in the BPM when tapping at sufficiently high tempos.
    2. Reset the calculated BPM after a long pause. A long pause most likely means the user stopped tapping, so we don't want to include that long interval in the BPM calculation.

@sakertooth
Move GUI controls into member variables
c243ff4
@sakertooth
Remove showDecimal variable
be7387e
@sakertooth
Rename onBpmClick function to tap
1ca8a15
@sakertooth
Move play functionality outside GUI code
88d8473
@sakertooth
Remove keyPressEvent handler
22a62bb 
Not needed
@sakertooth
Rename updateLabels function to update
9476de2
@sakertooth
Make update function private
9a4913e
@sakertooth
Move sync functionality outside GUI code
41f2c67
@sakertooth
Simplify Qt connections
82b757c
@sakertooth
Add and use reset function
ac4a931
@sakertooth
Remove unused includes
c885e13
@sakertooth
I dont know why there is so much whitespace in the copyright
8505f14
@sakertooth
Access BPM through function, removing friend access inside TapTempo
aa05d74 
Removing friend access to TapTempoView in TapTempo helps with the GUI/Core split
@sakertooth
Make closeEvent handler private
61570f0
@sakertooth
Change algorithm
35b81c9 
Now averaging over a few intervals
@sakertooth
Reset after a long pause
008dddd
@sakertooth
Apply an EMA filter to the BPM calculation
d7fa137 
This helps minimize jitter, which are small fluctuations over time that happen quickly between BPM estimates
@sakertooth
Add newline
765ff2d
@sakertooth sakertooth marked this pull request as ready for review October 18, 2025 21:06
@AW1534
Copy link
Member

AW1534 commented Nov 3, 2025

I've tested, and found no issues. This is definitely an improvement from master. I think perhaps there should be a label upon opening the tool saying something like "Click to begin".

@sakertooth
Copy link
Contributor Author

sakertooth commented Nov 3, 2025

I've tested, and found no issues. This is definitely an improvement from master.

Thanks for testing!

I think perhaps there should be a label upon opening the tool saying something like "Click to begin".

Yeah, an indicator might be better UX. I'll look into adding that.

@sakertooth
Have tap button text show click to begin indicator
b644e63
@sakertooth
Reset strings when closing window
a9215e0
@sakertooth
Lower alpha (smoother response)
4e70c50
@sakertooth
Add adaptive EMA scaling
8feea37 
Early taps (as well as taps with high interval variance in general) need more responsive BPM updates so we can get to a target range quickly. Once we have reached the target BPM range, we want the BPM readings to become more stable as the user trying to tap with more consistency.

We use EMA to reduce jitter in the BPM readings, but the amount of smoothing we apply should change dynamically to align with how the user is tapping.

Adaptive EMA scaling adjusts the smoothing factor dynamically to account for this based on how much the tap intervals vary. If the variation is high, then the BPM updates are more responsive (allowing for rapid changes). If the variation is low, then the BPM updates are less responsive (slower, more stable changes).
@sakertooth
Copy link
Contributor Author

sakertooth commented Nov 5, 2025

I added the "Click to begin" indicator as well as another major improvement to the BPM calculation @AW1534 👍

@AW1534
Copy link
Member

AW1534 commented Nov 5, 2025

The indicator is definitely a good improvement. I don't notice the difference to the BPM calculation, but i tested and it works well

@sakertooth
Copy link
Contributor Author

sakertooth commented Nov 5, 2025

The indicator is definitely a good improvement. I don't notice the difference to the BPM calculation, but i tested and it works well

The problem was more noticeable in the beginning when trying to tap to a high tempo as it would take a long time for it to ramp up. I just added a feature that solves this to a certain degree.

@sakertooth
Do not reset m_beat when resetting plugin
f94334d 
So the metronome doesnt play the incorrect sound after a reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sakertooth @AW1534