[FIX] Memory issue (WIP) #1510
Merged
[FIX] Memory issue (WIP) #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
So I did a lot of testing and could't replicate the very high consuming (1.5GB RAM usage) anymore. I could also not replicate the rebuild loop even with the new command as stated above. However there are still benefits when going back to vue cli ->
I will test for some more time and keep you updated, if I notice anything. Thanks! |
|
I have tested with that command for a long time now and did not experience a single loop, so I think this can be merged and pushed to docker images etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, experimenting with going back to the Vue CLI to handle the rebuilding.
Previously this approach introduced a bug which caused a rebuild loop, which was why the new
watch-for-changesfunction was written, but that function is memory intensive. But there have been some architectural changes since, so I'm giving this a second shot.This will not be merged until I can verify 100% that it does not re-introduce the old infinite rebuild loop bug.
Category: Bugfix
Overview
Issue Number #1500
New Vars N/A
Screenshot N/A
Code Quality Checklist (Please complete)