documentation update and typehints for visualization #372
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
+ Coverage 77.75% 77.78% +0.03%
===========================================
Files 22 22
Lines 2063 2066 +3
Branches 475 475
===========================================
+ Hits 1604 1607 +3
Misses 339 339
Partials 120 120
Continue to review full report at Codecov.
|
| order: | ||
|
|
||
| | plotId | [plotName] | plotTypeSimulation | plotTypeData | datasetId | ... | ||
| | plotId | [plotName] | [plotTypeSimulation] | [plotTypeData] | [datasetId] | ... |
There was a problem hiding this comment.
so far, I think datasetId and xValues are mandatory.
Question: If we want to change that, that would mean the only mandatory column would be plotId, does this make sense? What should then be plotted if just plotId is provided?
There was a problem hiding this comment.
Well, in a way it still makes sense, as it allows to specify values different from defaults only for a subset of optional columns. However, if there is only one column in vis_spec, maybe we should show some message.
doc/documentation_data_format.md
Outdated
| - `yScale` [STRING] | ||
| - `yScale` [STRING, OPTIONAL] | ||
|
|
||
| Scale of the observable, can be `lin`, `log`, or `log10`. |
There was a problem hiding this comment.
Adding: Default is 'lin'?
Release 0.1.5 Library: * New create empty observable function (issue 386) (#387) * Deprecate petab.sbml.globalize_parameters (#381) * Fix computing log10 likelihood (#380) * Documentation update and typehints for visualization (#372) * Ordered result of `petab.get_output_parameters` * Fix missing argument to parameters.create_parameter_df Documentation: * Add overview of supported PEtab feature in toolboxes * Add contribution guide * Fix optional values in documentation (#378)
No description provided.