This repository was archived by the owner on Dec 26, 2022. It is now read-only.
β¨ Guild & Channel properties for APIObjects #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 9 9
Lines 100 100
=======================================
Hits 90 90
Misses 10 10 Continue to review full report at Codecov.
|
d1afaca to
c117ea9
Compare
Member
Author
|
I've switched to the boring solution where it has to be done manually π Linters don't work well otherwise. |
c117ea9 to
fb6a3ef
Compare
Sigmanificient
suggested changes
Dec 9, 2021
b18c58a to
f5f027d
Compare
Member
Author
|
Theoretically all the logic should be implemented. Now I just need to add the properties π |
Sigmanificient
approved these changes
Dec 12, 2021
trag1c
suggested changes
Dec 12, 2021
Co-authored-by: trag1c <[email protected]>
β¦to properties
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
9fd1c40 to
f138503
Compare
Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Sigmanificient
suggested changes
Dec 12, 2021
Sigmanificient
approved these changes
Dec 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a way to get
Guild, andChannelsfrom APIObjects without fetching more info from the discord API. Using theGUILDSIntent, Guild and Channel info is cached to be used later.Also made it so intents can be given as a iterable since I tried to do that before I knew you needed to add them π’ Intents are also
Intents.all()by default. This way new users will automatically have all features that require certain intents so it should be a little easier to use.Middleware is the most important to review. Everything in the objects directory just has
ChannelPropretyorGuildPropertyadded to it and I think I changed the default value forpositionin theChannelobject to 0 to make it easier to work with.Check off the following