This repository was archived by the owner on Dec 26, 2022. It is now read-only.
👷 Updated package to use Poetry #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is the lock file supposed to be included? |
Member
Author
yes |
Arthurdw
approved these changes
May 28, 2022
Member
Arthurdw
left a comment
There was a problem hiding this comment.
Looks right (havn't tested locally)
trag1c
suggested changes
May 28, 2022
Co-authored-by: trag1c <[email protected]> Co-authored-by: trag1c <[email protected]>
Co-authored-by: trag1c <[email protected]>
Sigmanificient
suggested changes
May 28, 2022
Member
Sigmanificient
left a comment
There was a problem hiding this comment.
The coverage action is failing due to missing pytest command, and the
zunda-arrow
reviewed
May 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 64.98% 65.01% +0.03%
==========================================
Files 184 183 -1
Lines 5971 5968 -3
==========================================
Hits 3880 3880
+ Misses 2091 2088 -3 Continue to review full report at Codecov.
|
Member
Author
|
All changes are implemented, all checks pass. 2 approvals. Merging now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pincer now used Poetry instead of a mix of pip and Pipfile. This will make it easier to publish and removes the hassle.
Check off the following