Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix jobdsl error #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: fix jobdsl error #3012

merged 1 commit into from
Jun 25, 2024

Conversation

@purelind
Copy link
Collaborator

@purelind purelind commented Jun 25, 2024 •
edited by qodo-merge-pro bot
Loading

User description

fix jobdsl error

PR Type

Bug fix

Description

  • Fixed incorrect closing quote in scriptPath string across multiple Groovy files.
  • Ensured consistency and correctness in pipeline job definitions.

Changes walkthrough 📝

Relevant files
Bug fix
14 files
pull_common_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_common_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_e2e_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_e2e_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_br_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_br_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_common_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_common_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_copr_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_copr_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_ddl_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_ddl_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_jdbc_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_jdbc_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_lightning_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_lightning_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_mysql_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_mysql_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_nodejs_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_nodejs_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_integration_python_orm_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_integration_python_orm_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_mysql_client_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_mysql_client_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_sqllogic_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_sqllogic_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     
pull_tiflash_test.groovy
Fix incorrect closing quote in scriptPath                               

jobs/pingcap/tidb/release-8.2/pull_tiflash_test.groovy

  • Fixed incorrect closing quote in scriptPath string.
 +1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 25, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request fixes a typo in the scriptPath parameter in several pipeline job definitions. The change is straightforward and does not introduce any new code. Therefore, it is a low-risk change.

There are no potential problems with this change.

Suggestions:

  • It is always good to add more details about the changes made in the pull request description to make it easier for reviewers to understand the context of the changes.
  • Consider using a linter or a code formatter to avoid syntax errors and typos in the future.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo June 25, 2024 10:02
@ti-chi-bot ti-chi-bot bot added the size/S label Jun 25, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jun 25, 2024

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 2
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review None

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Jun 25, 2024

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
Ensure the scriptPath is correctly formatted with double quotes

Ensure that the scriptPath is correctly formatted with double quotes to avoid potential
syntax errors.

jobs/pingcap/tidb/release-8.2/pull_common_test.groovy [19]

+scriptPath("pipelines/pingcap/tidb/release-8.2/pull_common_test.groovy")
 
-
  • Apply this suggestion
Suggestion importance[1-10]: 10

Why: The suggestion correctly identifies and fixes a syntax error in the scriptPath by replacing a single quote with double quotes, which is crucial to avoid script failures.

10

@ti-chi-bot ti-chi-bot bot merged commit 3f5b1cf into PingCAP-QE:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

Assignees

No one assigned

Labels

approved area/jobs/jenkins-DSL Bug fix lgtm Review effort [1-5]: 2 size/S

Projects

EE - CI/CD system
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@purelind