Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wuhuizuo
Copy link
Collaborator

Reverts #3024

@ti-chi-bot ti-chi-bot bot requested a review from purelind July 11, 2024 10:24
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that this PR is intended to revert a previous fix that was implemented to work around a problem with building Tikv on AMD64 architecture. The diff shows that the changes were made to the check-tiup.sh script, where the part that checks the git_sha of Tikv was modified to remove the workaround.

It's not clear from the pull request why this fix is being reverted. Therefore, it's important to ask the author for more information on why the change is being made and what issues were encountered that led to this decision.

If reverting the fix is necessary, it's important to consider the potential problems that might arise from this. Specifically, if the problem with building Tikv on AMD64 is not resolved, then this could lead to build failures or other issues down the line.

One suggestion to address this would be to re-implement the workaround in a way that doesn't cause issues, or to investigate the root cause of the problem and address it directly. Additionally, it's important to thoroughly test the changes to ensure that they don't cause any issues in the build process.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 11, 2024
@wuhuizuo wuhuizuo added lgtm and removed size/XS labels Jul 11, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

@qodo-merge-pro
Copy link
Contributor

PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 50850ce into main Jul 11, 2024
@ti-chi-bot ti-chi-bot bot deleted the revert-3024-fix/workaround-tikv-amd64-tiup branch July 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants