I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the author is preparing to create a new release-8.3 branch. Looking at the diff, there are a few changes made to the Jenkins pipeline scripts to include the new release branch. Specifically, the cd/release_all_images_by_branch_for_internal.groovy, cd/nightly/release-all-images-by-branch.groovy, cd/nightly/tiup-release-tidb-master-nightly.groovy, cd/tiup/tiup-mirror-update-multi-products.groovy and cd/tiup/tiup-online-mirror-atom.groovy files have been modified.

There seem to be no major issues with the changes. The changes are basically adding a new release branch in the pipeline scripts. However, there are a few minor suggestions that can be made to improve the code:

• In cd/release_all_images_by_branch_for_internal.groovy, the cron expression seems to have unnecessary white spaces. It can be tidied up by removing the spaces.
• In cd/nightly/release-all-images-by-branch.groovy, the RELEASE_TAG has been updated to v8.4.0-alpha, but the comment still says v8.3.0-alpha. The comment should be updated to reflect the correct release tag.
• In cd/tiup/tiup-mirror-update-multi-products.groovy and cd/tiup/tiup-online-mirror-atom.groovy, the version number of TiDB has been hard-coded as v8.4.0-alpha. It would be better to get the version number dynamically instead of hard-coding it.

Overall, the changes look good and can be merged once the suggested improvements are made.

/hold

wait for few days.

[LGTM Timeline notifier]

Timeline:

• 2024-08-20 13:25:18.97117004 +0000 UTC m=+271914.105620160: ☑️ agreed by purelind.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/unhold