Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(scripts/artifacts): add checks for enterprise images #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(scripts/artifacts): add checks for enterprise images #3091

merged 1 commit into from
Aug 26, 2024

Conversation

@wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 26, 2024

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 26, 2024 09:36
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes:

  • Renamed ImageMap to imageMap.
  • Added enterprise section to imageMap.
  • Changed the naming convention of enterprise images.
  • Modified the main function to check both community and enterprise images.
  • Re-structured the output of the checkImages function.

Potential Problems:

  • It is not clear if the changes made are really necessary.
  • The description of the pull request is very brief and does not provide enough context.

Fixing Suggestions:

  • Add more details to the pull request description to explain why these changes are necessary.
  • Check with the author of the pull request to provide more context around the changes made.
  • Ensure that the changes do not break any existing functionality.
  • Consider adding unit tests to validate the changes made.

@ti-chi-bot ti-chi-bot bot added the size/L label Aug 26, 2024
purelind
purelind approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 26, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-26 09:38:05.556492476 +0000 UTC m=+776680.690942599: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit ef64364 into main Aug 26, 2024
@ti-chi-bot ti-chi-bot bot deleted the fix/artifacts-check-script branch August 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purelind purelind purelind approved these changes

Assignees

No one assigned

Labels

approved lgtm size/L

Projects

EE - CI/CD system
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wuhuizuo @purelind