Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(tiflash): update CI/CD pipelines #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore(tiflash): update CI/CD pipelines #3219

merged 1 commit into from
Nov 8, 2024

Conversation

@wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 8, 2024 •
edited
Loading

update the build script path.

Ref pingcap/tiflash#9587

Signed-off-by: wuhuizuo [email protected]

@wuhuizuo
chore(tiflash): update CI/CD pipelines
df3c3c0 
update the build script path.

Ref #3216

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind November 8, 2024 07:46
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The key changes in this PR are updating the build script path from release-centos7-llvm to release-linux-llvm and adding a new condition branch for it. Additionally, some paths are updated in the pull_integration_test.groovy file.

There don't seem to be any potential problems with this change.

Fixing suggestions:

  • The changes seem reasonable, so the PR can be merged after a quick review.
  • However, the comments in the code indicate that there is still a TODO to replace "release-centos7-llvm" to "release-linux-llvm" in pull_integration_test.groovy. This should be addressed in a separate PR.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 8, 2024

The CD pipeline is for old devbuild, it will not be deprecated in recently future weeks.

purelind
purelind approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 07:59:04.668747055 +0000 UTC m=+1200657.507902601: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2024
@purelind purelind mentioned this pull request Nov 8, 2024
Closed
@ti-chi-bot ti-chi-bot bot merged commit e2be0c5 into main Nov 8, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/update-tiflash-build-commands-starts-v8.5 branch November 8, 2024 08:03
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purelind purelind purelind approved these changes

Assignees

No one assigned

Labels

approved area/jenkins-pipelines lgtm size/S

Projects

EE - CI/CD system
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wuhuizuo @purelind