Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixed GP interpolations #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 12, 2021
Merged

fixed GP interpolations #57

merged 14 commits into from
May 12, 2021

Conversation

@alexander-wise
Copy link
Contributor

I made an effort to go through and fix other Stheno functions since gp_fast is no longer using Stheno, but I did not test them all.

alexander-wise and others added 13 commits October 28, 2020 02:22
eford
eford approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@eford eford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eford
Copy link
Member

eford commented May 12, 2021

It looks like the CI tests failed because you need to add KernelFunctions to dependancies.
Doing Pkg.add("KernelFunctions") should add it. Then, it'll want you to add a compat line to the Project.toml specifying the version that it's know to work with. Then commit and push the updated Project.toml, and there's a good chance it'll pass.

@alexander-wise
Copy link
Contributor Author

Yup, that worked!

@eford eford merged commit 679dda7 into RvSpectML:main May 12, 2021
@alexander-wise alexander-wise deleted the main branch July 20, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eford eford eford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-wise @eford