Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix for sonarcloud-reported bug #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from May 25, 2022
Merged

fix for sonarcloud-reported bug #1945

merged 5 commits into from May 25, 2022

Conversation

@ghost
Copy link

@ghost ghost commented May 15, 2022

Summary of changes

invalid "+" operation between incompatible types (str and type) - sonarcloud-reported bug

Changed exception string construction to use f"" format

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Added tests for any changes that have a runtime impact. (Defeated me 😦 but force-triggered the Exception and it works)
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ghost ghost self-requested a review May 15, 2022 16:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented May 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 88.437% when pulling 2ef6f80 on gjhiggins:fix-sonarcloud-reported-bug into a3a4611 on RDFLib:master.

aucampia
aucampia approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aucampia aucampia requested a review from a team May 17, 2022 13:06
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 17, 2022
@aucampia
Copy link
Member

aucampia commented May 21, 2022

Will merge by 2022-05-25 if there is no further feedback.

@aucampia aucampia merged commit 32979d1 into RDFLib:master May 25, 2022
@ghost ghost deleted the fix-sonarcloud-reported-bug branch May 26, 2022 10:03
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coveralls @aucampia @gjhiggins