Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sixlowpan: Clean-up, take IPv6 out, and refactor to netapi #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

sixlowpan: Clean-up, take IPv6 out, and refactor to netapi #1680

wants to merge 25 commits into from

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Sep 17, 2014

Depends on #1448, #1984 (both merged), #1967, and #2027 (merged).

Had to restructure this PR a little bit due to the introduction of #1967. I also used the opportunity and introduced byteorder to IPv6 (where I already needed parts of it, namely headers and addresses), so every time one tries to send in wrong order, there will be a nice compiler error now :-).

@miri64 miri64 added Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Area: network Area: Networking 2 - Working Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. and removed 2 - Working labels Sep 17, 2014
@miri64 miri64 added this to the Release NEXT MAJOR milestone Sep 17, 2014
@OlegHahm
Copy link
Member

OlegHahm commented Sep 18, 2014

Showing 91 changed files with 10,380 additions and 806 deletions. - this PR's title appears to match its content, but I have no clue how to review...

@N8Fear
Copy link

N8Fear commented Sep 18, 2014

I guess the commits from #1492, #1448, and #1638 are included in this PR (At least that is what I can gather from a superficial glance at the commit names).
So the scope of this PR will likely be reduced as soon as the others (or at least the ones that are mergable in a stand alone way) are merged...

@OlegHahm
Copy link
Member

OlegHahm commented Sep 18, 2014

phew

@LudwigKnuepfer LudwigKnuepfer added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 18, 2014
@miri64
Copy link
Member Author

miri64 commented Sep 18, 2014

What @N8Fear is saying ;-)

@miri64
Copy link
Member Author

miri64 commented Sep 18, 2014

But if you like to review anyways: the relevant files for this PR are currently:

  • sys/net/include/sixlowpan.h
  • sys/net/link_layer/sixlowpan/core.c
  • tests/sixlowpan/main.c

@miri64
Copy link
Member Author

miri64 commented Sep 18, 2014

Last commits add the following files into the mix:

  • tests/sixlowpan/framework.c
  • tests/sixlowpan/framework.h

Tests fail on msba2 since pktbuf is not cleaned up correctly. Maybe that hints to the problems discussed on the mailing list. I will look into it tomorrow.

@miri64 miri64 added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 19, 2014
@LudwigKnuepfer LudwigKnuepfer changed the title sixlowpan: This changes EVERYTHING WIP: sixlowpan: This changes EVERYTHING Sep 19, 2014
@miri64 miri64 force-pushed the 6lowpan-fix-major branch 2 times, most recently from 3383065 to 5c23565 Compare September 29, 2014 13:58
@miri64 miri64 force-pushed the 6lowpan-fix-major branch 7 times, most recently from 9199e86 to 09a22ec Compare October 7, 2014 21:25
@miri64 miri64 mentioned this pull request Oct 8, 2014
Merged
@miri64 miri64 force-pushed the 6lowpan-fix-major branch 2 times, most recently from ea86a2b to c8bd664 Compare October 9, 2014 09:15
@miri64 miri64 force-pushed the 6lowpan-fix-major branch from 2e3c5e5 to 0c7e3ec Compare January 13, 2015 06:28
@miri64
Copy link
Member Author

miri64 commented Jan 13, 2015

Rebased to #1967

@miri64 miri64 force-pushed the 6lowpan-fix-major branch from 3865250 to d253c63 Compare January 13, 2015 21:28
This was referenced Jan 24, 2015
Merged
Merged
@OlegHahm OlegHahm modified the milestones: Release NEXT MAJOR, Network Stack Task Force Feb 6, 2015
@OlegHahm OlegHahm added NSTF and removed NSTF labels Feb 6, 2015
@miri64 miri64 modified the milestone: Network Stack Task Force Feb 8, 2015
@miri64 miri64 added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 8, 2015
@miri64
Copy link
Member Author

miri64 commented Feb 8, 2015

On hold, until I'm done with the IPv6 implementation (see #2278). Please don't ask me to rebase this PR, until #2003 is under review.

@OlegHahm
Copy link
Member

OlegHahm commented Feb 21, 2015

Can we close this?

@miri64
Copy link
Member Author

miri64 commented Feb 21, 2015

@OlegHahm see #1680 (comment). I'll decide when I'm done with #2454 if I recycle this one, or open a new one.

@OlegHahm
Copy link
Member

OlegHahm commented Feb 22, 2015

ok

@miri64
Copy link
Member Author

miri64 commented Mar 23, 2015

New port in #2614 and onwards.

@miri64 miri64 closed this Mar 23, 2015
@miri64 miri64 deleted the 6lowpan-fix-major branch May 26, 2015 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @OlegHahm @N8Fear @LudwigKnuepfer