Thanks to visit codestin.com
Credit goes to github.com

Skip to content

board/iot-lab_M3: clean up and GPIO definitions in periph_conf.h #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

board/iot-lab_M3: clean up and GPIO definitions in periph_conf.h #1757

wants to merge 2 commits into from

Conversation

@thomaseichinger
Copy link
Member

@thomaseichinger thomaseichinger commented Oct 1, 2014

No description provided.

@thomaseichinger thomaseichinger added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Oct 1, 2014
@thomaseichinger thomaseichinger added this to the Release NEXT MAJOR milestone Oct 1, 2014
@haukepetersen
Copy link
Contributor

haukepetersen commented Oct 2, 2014

I just had an idea for making this even nicer: as GPIO_x_PIN is always equal to GPIO_x_EXTI_LINE, why not change the cpu/stm32f1/gpio.c, so it uses GPIO_x_PIN instead directly.
-> see PR against your branch.

@thomaseichinger
Copy link
Member Author

thomaseichinger commented Oct 2, 2014

I also added using GPIO_x_PIN usage into the ISRs. Sorry, squashed into your commit.

haukepetersen
haukepetersen reviewed Oct 2, 2014
View reviewed changes
cpu/stm32f1/periph/gpio.c
Copy link
Contributor

@haukepetersen haukepetersen Oct 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look strange, I think the original version was correct?!

Copy link
Contributor

@haukepetersen haukepetersen Oct 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be config[GPIO_IRQ_0].cb(config[GPIO_IRQ_0].arg);

@thomaseichinger thomaseichinger added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Oct 2, 2014
@thomaseichinger
Copy link
Member Author

thomaseichinger commented Oct 2, 2014

will get further additions

@thomaseichinger
Copy link
Member Author

thomaseichinger commented Oct 8, 2014

Cleanup included in #1756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@haukepetersen haukepetersen

Labels

Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2014.12

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaseichinger @haukepetersen