Introduction of an of-manager for RPL. #1080

fabratu · 2014-04-30T10:50:01Z

The of-manager should gather all available of´s and initialize the preferred one, based on RPL_DEFAULT_OCP in rpl_config.h.

OlegHahm · 2014-04-30T11:40:47Z

sys/net/routing/rpl/rpl.c

Please use C style comments:

/* initialize objective function manager */

OlegHahm · 2014-04-30T11:41:48Z

Doxygen documentation is missing.

fabratu · 2014-04-30T12:12:12Z

Fixed. Documentation is now only missing for the rest (old) rest of RPL. If there is time, if will document these parts also.

mehlis · 2014-04-30T12:13:28Z

sys/net/routing/rpl/rpl_of_manager.c

mehlis · 2014-04-30T12:16:57Z

@OlegHahm talked to @emmanuelsearch : this should go in the next release, changed milestone to next

OlegHahm · 2014-04-30T12:20:47Z

As far as I can tell this is neither related to testing nor to documentation. Thus, it's not in the focus of the upcoming release (as discussed on Monday). If it is merged by then, it can go in, of course, but I would strongly object waiting for this PR to be merged for this release.

fabratu · 2014-04-30T12:23:52Z

Fixed.

emmanuelsearch · 2014-04-30T12:28:54Z

I agree with Oleg that the top priority for the next release is the documentation and the restructuring. But new features are not the top priority.

mehlis · 2014-05-02T12:13:33Z

sys/net/routing/rpl/rpl_of_manager.c

please move NUMBER_IMPLEMENTED_OFS in this file, this define is not used in any other place and hard to find now

I second @mehlis. And rpl_objective_functions can be removed, too, right?

mehlis · 2014-05-02T12:14:38Z

@FabianBrandt with a last function test on Monday, we can merge this PR, that the SWP team can make use of it

mehlis · 2014-05-21T07:42:55Z

@FabianBrandt can you please rebase to trigger travis?

mehlis · 2014-06-14T13:16:32Z

@FabianBrandt my comment from 5/24 is unresolved

fabratu · 2014-07-07T17:07:29Z

@mehlis Sry for the long wait - somehow overlooked this PR and the urgency. New commit is there.

OlegHahm · 2014-09-16T14:50:53Z

Please rebase.

OlegHahm · 2014-09-28T17:22:08Z

@FabianBrandt: ping

fabratu · 2014-09-29T14:09:57Z

Ping arrived. My local repo is broken - will rebase after fixing that.

Edit: madness continues. Now with a fresh clone and remote fetch every make is messed with a lot -Wpedantic from guys like unsigned long reserved:20; /**< reserved. Set to 0. */ I thought they were gone?

fabratu · 2014-09-29T14:40:16Z

Since the mentioned error is not touched by the PR - this one is rebased.

OlegHahm · 2014-09-29T15:57:46Z

sys/net/include/rpl/rpl_of_manager.h

Don't use `/**' for the license header - otherwise doxygen will parse it.

This one is still missing.

fabratu · 2014-09-29T16:22:42Z

Done

OlegHahm · 2014-11-10T22:33:08Z

sys/net/include/rpl/rpl_of_manager.h

Broken indentation.

OlegHahm · 2014-11-18T18:09:52Z

@FabianBrandt: I think there are some tiny details left before we can merge this.

fabratu · 2014-11-24T20:28:17Z

Fixed the indentation and rebased.

fabratu · 2014-11-24T22:33:44Z

@OlegHahm I think everything is ready now.

OlegHahm · 2014-11-25T10:57:32Z

sys/net/include/rpl/rpl_of_manager.h

Wrong prefix. Correct would be rpl_of_manager_init().

OlegHahm · 2014-11-25T11:00:25Z

@FabianBrandt, sorry, I guess my former statement was a bit hasty.

fabratu · 2014-11-26T08:33:23Z

@OlegHahm Everything is ready reloaded.

The of-manager should gather all available of´s and initialize the prefered one, based on rpl_config.h.

Introduction of an of-manager for RPL.

OlegHahm added the network label Apr 30, 2014

OlegHahm reviewed Apr 30, 2014
View reviewed changes

sys/net/routing/rpl/rpl.c Outdated

Copy link

Member

OlegHahm Apr 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use C style comments:

/* initialize objective function manager */

mehlis reviewed Apr 30, 2014
View reviewed changes

sys/net/routing/rpl/rpl_of_manager.c

Copy link

Contributor

mehlis Apr 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

OlegHahm added this to the Release NEXT MAJOR milestone Apr 30, 2014

OlegHahm self-assigned this Apr 30, 2014

mehlis modified the milestones: Release 2014.05, Release NEXT MAJOR Apr 30, 2014

mehlis reviewed May 2, 2014
View reviewed changes

OlegHahm modified the milestones: Release NEXT MAJOR, Release 2014.05 May 4, 2014

fabratu mentioned this pull request May 14, 2014

Split RPL into core and mode related functions. #1167

Merged

Kijewski added the NEEDS SQUASHING label May 21, 2014

OlegHahm removed the NEEDS SQUASHING label Jul 16, 2014

LudwigKnuepfer changed the title ~~Introduction of a of-manager for RPL.~~ Introduction of an of-manager for RPL. Sep 29, 2014

fabratu force-pushed the of_manager branch 2 times, most recently from 05a4ff8 to c8f8da8 Compare September 29, 2014 14:39

OlegHahm reviewed Sep 29, 2014
View reviewed changes

fabratu force-pushed the of_manager branch from 1f1809f to f7f8ad7 Compare September 29, 2014 16:19

OlegHahm reviewed Nov 10, 2014
View reviewed changes

sys/net/include/rpl/rpl_of_manager.h Outdated

Copy link

Member

OlegHahm Nov 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken indentation.

fabratu force-pushed the of_manager branch from 3be8825 to 16d2371 Compare November 24, 2014 20:27

fabratu force-pushed the of_manager branch 2 times, most recently from a8dbb39 to 3d6d427 Compare November 24, 2014 21:48

OlegHahm reviewed Nov 25, 2014
View reviewed changes

sys/net/include/rpl/rpl_of_manager.h Outdated

Copy link

Member

OlegHahm Nov 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong prefix. Correct would be rpl_of_manager_init().

fabratu force-pushed the of_manager branch from 424e577 to 1d21fc1 Compare November 26, 2014 08:32

fabratu force-pushed the of_manager branch from be035f2 to 7744b43 Compare November 26, 2014 10:01

Introduction of a of-manager for RPL.

38d9b42

The of-manager should gather all available of´s and initialize the prefered one, based on rpl_config.h.

fabratu force-pushed the of_manager branch from 7744b43 to 38d9b42 Compare November 27, 2014 16:19

OlegHahm added a commit that referenced this pull request Nov 27, 2014

Merge pull request #1080 from fabianbrandt/of_manager

b358d85

Introduction of an of-manager for RPL.

OlegHahm merged commit b358d85 into RIOT-OS:master Nov 27, 2014

Introduction of an of-manager for RPL. #1080

Introduction of an of-manager for RPL. #1080

Uh oh!

Conversation

fabratu commented Apr 30, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Apr 30, 2014

Uh oh!

fabratu commented Apr 30, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mehlis commented Apr 30, 2014

Uh oh!

OlegHahm commented Apr 30, 2014

Uh oh!

fabratu commented Apr 30, 2014

Uh oh!

emmanuelsearch commented Apr 30, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mehlis commented May 2, 2014

Uh oh!

mehlis commented May 21, 2014

Uh oh!

mehlis commented Jun 14, 2014

Uh oh!

fabratu commented Jul 7, 2014

Uh oh!

OlegHahm commented Sep 16, 2014

Uh oh!

OlegHahm commented Sep 28, 2014

Uh oh!

fabratu commented Sep 29, 2014

Uh oh!

fabratu commented Sep 29, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabratu commented Sep 29, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Nov 18, 2014

Uh oh!

fabratu commented Nov 24, 2014

Uh oh!

fabratu commented Nov 24, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Nov 25, 2014

Uh oh!

fabratu commented Nov 26, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants