cpu/esp32: fix to be able to use SPI flash drive with pkg_littlefs #12803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To see debug or error messages during SPI flash drive initialization, spi_flash_drive_init has to be called after stdio_init.
17 tasks
Contributor
|
Tested on my machine and it works. It seems reasonable. I will wait for @benpicco for any objections. |
benpicco
approved these changes
Nov 25, 2019
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Small change and I also checked that it's working now.
I checked if esp8266 needs this too, but there it's already working.
Contributor
Author
|
@MrKevinWeiss @benpicco Thanks for reviewing, testing and merging 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides a fix to be able to use
pkg_littlefswith the EPS32 SPI flash drive.pkg_littlefsuses themtdmodule which has to be in IRAM. Otherwise the first access to the SPI flash drive leads to crash with optimized code. Furthermore,spi_flash_drive_init has to be called afterstdio_init` to see debug or error messages during SPI flash drive initialization.With this PR,
tests/pkg_littlefsworks for ESP32 boards.This PR belongs to the series of PRs, each with very small changes that fix automatic tests on ESP32 boards.
Testing procedure
Make, flash and test with and without this PR.
Without this PR, the test should crash.
Issues/PRs references