net_help: Cleanup #2019
net_help: Cleanup #2019
Conversation
The od module does the same, much less specialized, much more sophisticated.
Used nowhere; alternative: ipv6_addr_is_equal(), since other use-cases (is an IPv6 address smaller than the other) are not applicable anyway.
bf05c86 to
a404357
Compare
|
After testing this function I have to admit I really don't understand what this function does :/ |
There was a problem hiding this comment.
I find the original code more readable.
|
|
|
But at least in ICMP (where it is used to calculate the checksum, and where the checksum is [in most cases ;-)] correct according to wireshark) it's supposed to be
But I neither see the one's complement, nor is it the sum as I would expect a sum would look like. |
|
Reverted the negatively criticized changes. |
|
Remembered my telematics classes and the Internet Checksum. Updated the documentation accordingly. |
|
ACk. Squash and merge at will. |
387f355 to
c9219b8
Compare
In addition to #1984 this cleans up the
net_helpmodule.printArrayRange(). Alternative: theodmoduleIPV6_CMP_ADDR(). Alternative:ipv6_addr_is_equal()/ipv6_addr_equal()(as of WIP IPv6 refactoring #2003). Other comparisons between IPv6 addresses would be odd anywaycsum()according to Coding Conventions tonet_help_csum()