tests: define random default GPIOs to pass Travis builds #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hm, I don't really like this. What happens in the case you connect one of these sensors to a board externally? Then you would need to edit the features of that board in order to build... My solution would be to change the default pins to the lowest ones (e.g. GPIO_0, GPIO_1...) and open an issue so that we think about the handling of device drivers in Travis. Sounds feasible? |
2e6b186 to
76326e9
Compare
Member
Author
|
@haukepetersen updated |
tests/driver_l3g4200d/Makefile
Outdated
Contributor
There was a problem hiding this comment.
how about using GPIO_1 here, setting both to the same default port seems awkward, and 2 GPIOs should be fine for almost every board...
Contributor
|
looks good now, maybe change the one default pint to |
76326e9 to
e7ae2f6
Compare
Member
Author
|
@haukepetersen I did. |
Contributor
|
ACK when Travis is happy |
Member
Author
|
and Go |
thomaseichinger
added a commit
that referenced
this pull request
Nov 21, 2014
tests: define random default GPIOs to pass Travis builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests fail for boards providing periph_i2c (and periph_gpio) but default pins are not defined correctly.