-
Notifications
You must be signed in to change notification settings - Fork 163
Open
Description
There is a pull request template used by default across the entire ROCm organization here: https://github.com/ROCm/.github/blob/main/.github/pull_request_template.md. That template links to https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests, which has some sections that are not accurate or relevant for TheRock, such as:
- Target the default branch (usually the develop branch) for integration
- Once approved, the PR is brought onto internal CI systems and may be merged into the component during our release cycle, as coordinated by the maintainer
- We'll inform you once your change is committed
We could keep the same template but link to https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md#pull-requests instead, or we could customize further. See also:
- https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
- https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates
- https://github.com/pytorch/pytorch/blob/main/.github/PULL_REQUEST_TEMPLATE.md (minimal)
- Ideas: https://github.com/axolo-co/pull_request_template
- More ideas: https://graphite.com/guides/comprehensive-checklist-github-pr-template
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
TODO