Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplified the code for Hgg pre-selection and updated JetID #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2016
Merged

Simplified the code for Hgg pre-selection and updated JetID #18

merged 6 commits into from
Oct 11, 2016

Conversation

@andreypz
Copy link
Member

@andreypz andreypz commented Oct 6, 2016

  • Replaced if() statements with &&
  • Created a boolean method which checks pre-selection of a single di-photon

OlivierBondu
OlivierBondu requested changes Oct 7, 2016
View reviewed changes
Copy link
Member

@OlivierBondu OlivierBondu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the JetID recommendations have recently been updated for 13 TeV data (see twiki and original announcement)

@rateixei
Copy link

rateixei commented Oct 7, 2016 •
edited by andreypz
Loading

@andreypz please summarize all these changes to the repo in a presentation on Tuesday during our group meeting.

@rateixei
Copy link

rateixei commented Oct 7, 2016

Sorry, maybe I was misunderstood. I meant go ahead with the commit, with the changes @OlivierBondu suggested.
But, in our meeting next week, it would be good to have a summary of all the changes @andreypz has done in our repository during the past days, so everyone is aware of it. Unfortunately I had other commitments this week and couldn't follow closely.
I have no special problem with this commit!

@andreypz
Copy link
Member Author

andreypz commented Oct 7, 2016

Ok, I implemented new Jet ID, also adding a possibility to use Tight ID.
I'll give you time to have a look and will merge on Monday.

@andreypz andreypz changed the title Simplified the code for Hgg pre-selection Simplified the code for Hgg pre-selection and updated JetID Oct 7, 2016
@andreypz andreypz merged commit 0772e2f into master Oct 11, 2016
@andreypz andreypz deleted the dev-andrey-PreSel branch February 23, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierBondu OlivierBondu OlivierBondu approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreypz @rateixei @OlivierBondu