Improved node compilation in CompileNodeToValue (compile solution) #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
May want to at least try casting the constant expression to string in here, or else there may be rage
There was a problem hiding this comment.
UnableToCompileNode::fromConstFetch($constNode) maybe?
There was a problem hiding this comment.
Previously it was just returning a string with the const name, (e.g. FOO would compile to "FOO"), but surely this could cause undesired behaviour?
There was a problem hiding this comment.
This could indeed cause undesired behavior :-(
37ec979 to
1cd4e96
Compare
1cd4e96 to
47de68e
Compare
|
#98 created to improve |
Ocramius
added a commit
that referenced
this pull request
Aug 13, 2015
Improved node compilation in CompileNodeToValue (compile solution)
This was referenced Aug 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve both #64 and #19.
An alternate PR exists in #67
Depends on PR #96 being merged