Add ReflectionEnumCase#hasValueExpression()
#1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Sep 18, 2025
Ocramius
reviewed
Sep 18, 2025
test/unit/Fixture/Enums.php
Outdated
| { | ||
| } | ||
|
|
||
| enum InvalidEnum: int |
There was a problem hiding this comment.
Needs to be moved somewhere where it won't be analysed 🤔
I tried to add some explanations in the phpDoc |
ReflectionEnumCase#hasValueExpression()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Ocramius
We encountered an issue in PHPStan when someone analyse some (invalid) PHP code with an invalid backed enum with a case without value, PHPStan is crashing (phpstan/phpstan#7927).
Our strategy would be to introduce a
ReflectionEnumCase::hasValueExpressionmethod (basically a is valid enum case). And before adding it to the Phpstan/BetterReflection fork, I wanted to know if you would be interested/ok having this method in BetterReflection because it might have some other interest.I tried added a test case to show the situation.
Feel free to close this PR if the method doesn't interest you.
Thanks !