Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move photonOps and other PSF args to config #182

@ColeFMeldorf

Description

@ColeFMeldorf

Looking at this :

Rather than have "include_photonOps" always as an argument here, we should add to the config the ability to add additional arguments for creating psf objects. That would allow at runtime, without editing the code, somebody to specify the additional psf options for whatever it is they need.

For example, see : https://github.com/Roman-Supernova-PIT/phrosty/blob/8e7d57ec361c95c2860dc7bc1fa0c1eff45447a4/phrosty/pipeline.py#L128

and: https://github.com/Roman-Supernova-PIT/phrosty/blob/8e7d57ec361c95c2860dc7bc1fa0c1eff45447a4/phrosty/tests/phrosty_test_config.yaml#L38

Don't do this for this PR, but make an issue. This should probably be done at the same time as removing the if block I commented on in campari_runner.py.

Originally posted by @rknop in #175 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions