examples/movie_app/lib/main.dart (1)

97-109: DRY the repeated shape map.

Extract a shared const to avoid duplication and drift.

Apply this diff within the selected lines:

-    "shape": {"type": "roundedRectangleBorder", "borderRadius": 8},
+    "shape": _rrect8,

-    "shape": {"type": "roundedRectangleBorder", "borderRadius": 8},
+    "shape": _rrect8,

Add this above darkThemeJson:

const _rrect8 = {"type": "roundedRectangleBorder", "borderRadius": 8};

packages/stac/lib/src/parsers/painting/stac_text_style_parser.dart (1)

10-43: Optional: collapse theme mapping to a lookup to reduce boilerplate.

A small map or helper function can replace the large switch without changing behavior.

Example helper:

TextStyle? _pickTheme(TextTheme t, StacMaterialTextStyle s) => <StacMaterialTextStyle, TextStyle?>{
  StacMaterialTextStyle.displayLarge:  t.displayLarge,
  StacMaterialTextStyle.displayMedium: t.displayMedium,
  // ...rest...
}[s];

packages/stac_core/lib/foundation/effects/stac_gradient/stac_gradient.dart (5)

93-106: Add basic asserts for linear gradient inputs.

Catch common JSON/config mistakes early (length/stops).

   const StacGradient.linear({
     required this.colors,
     this.stops,
     this.begin,
     this.end,
     this.tileMode,
-  }) : gradientType = StacGradientType.linear,
+  }) : assert(colors.length >= 2, 'colors must have at least two entries'),
+       assert(stops == null || stops.length == colors.length,
+           'stops length must match colors length'),
+       gradientType = StacGradientType.linear,
        center = null,
        focal = null,
        focalRadius = null,
        radius = null,
        startAngle = null,
        endAngle = null;

---

118-131: Add validation for radial parameters.

Radius/focalRadius bounds and stops length help avoid runtime surprises.

   const StacGradient.radial({
     required this.colors,
     this.stops,
     this.center,
     this.focal,
     this.focalRadius,
     this.radius,
     this.tileMode,
-  }) : gradientType = StacGradientType.radial,
+  }) : assert(colors.length >= 2, 'colors must have at least two entries'),
+       assert(stops == null || stops.length == colors.length,
+           'stops length must match colors length'),
+       assert(radius == null || radius > 0, 'radius must be > 0'),
+       assert(focalRadius == null || focalRadius >= 0,
+           'focalRadius must be >= 0'),
+       gradientType = StacGradientType.radial,
        begin = null,
        end = null,
        startAngle = null,
        endAngle = null;

---

144-157: Add basic angle assertions for sweep.

Ensure ordering and stops integrity.

   const StacGradient.sweep({
     required this.colors,
     this.stops,
     this.center,
     this.startAngle,
     this.endAngle,
     this.tileMode,
-  }) : gradientType = StacGradientType.sweep,
+  }) : assert(colors.length >= 2, 'colors must have at least two entries'),
+       assert(stops == null || stops.length == colors.length,
+           'stops length must match colors length'),
+       assert(
+         startAngle == null || endAngle == null || endAngle >= startAngle,
+         'endAngle must be >= startAngle',
+       ),
+       gradientType = StacGradientType.sweep,
        begin = null,
        end = null,
        focal = null,
        focalRadius = null,
        radius = null;

---

216-218: Alias pattern is fine; consider top‑level wrappers if you want parameter docs/completions.

The const tear‑off works, but a named top‑level function can expose parameter docs without lints. Optional.

// Optional alternative:
// StacGradient StacLinearGradient({...}) => StacGradient.linear(...);

---

202-205: Docs: note angles are radians (already done for sweep) and default tileMode equals Flutter’s default (clamp).

Minor clarity tweak to reduce ambiguity in JSON authorship.

packages/stac_core/lib/core/converters/stac_text_style_converter.dart (1)

22-35: String handling is strict; optionally allow case-insensitive matches.

A small guard reduces authoring errors (“BodyMedium” vs “bodyMedium”).

-    if (json is String) {
+    if (json is String) {
+      final key = json.trim();
       for (final value in StacMaterialTextStyle.values) {
-        if (value.name == json) {
+        if (value.name == key) {
           return StacTextStyle.fromTheme(textTheme: value);
         }
       }

packages/stac/lib/src/parsers/widgets/stac_text/stac_text_parser.dart (1)

41-41: Minor: avoid temp allocation for empty children.

Use a const empty list to skip a runtime allocation when children is null.

-    var children = model.children ?? [];
+    final children = model.children ?? const <StacTextSpan>[];

Also applies to: 44-47

packages/stac_core/lib/foundation/text/stac_text_style/stac_text_style.dart (4)

257-261: Docs: JSON example uses style key; should be textTheme.

Update the example to match the actual schema.

-  /// ```json
-  /// { "type": "theme", "style": "titleMedium" }
-  /// ```
+  /// ```json
+  /// { "type": "theme", "textTheme": "titleMedium" }
+  /// ```

---

261-278: fromJson: make type parsing robust and explicit.

Cast to String?, normalize case, and avoid dynamic comparisons.

-  factory StacTextStyle.fromJson(Map<String, dynamic> json) {
-    final typeString = json['type'];
+  factory StacTextStyle.fromJson(Map<String, dynamic> json) {
+    final typeString = (json['type'] as String?)?.toLowerCase();
     StacTextStyleType parsedType = StacTextStyleType.custom;
     for (final value in StacTextStyleType.values) {
-      if (value.name == typeString) {
+      if (value.name == typeString) {
         parsedType = value;
         break;
       }
     }
     switch (parsedType) {
       case StacTextStyleType.custom:
         return StacCustomTextStyle.fromJson(json);
       case StacTextStyleType.theme:
         return StacThemeTextStyle.fromJson(json);
     }
   }

---

491-503: Make StacThemeTextStyle immutable/const; return consts from getters.

These instances are value objects; const reduces allocations.

-class StacThemeTextStyle extends StacTextStyle {
+class StacThemeTextStyle extends StacTextStyle {
   ...
-  StacThemeTextStyle({required this.textTheme})
+  const StacThemeTextStyle({required this.textTheme})
       : super._(type: StacTextStyleType.theme);

And in StacThemeTextStyles getters:

-  StacThemeTextStyle get bodyMedium =>
-      StacThemeTextStyle(textTheme: StacMaterialTextStyle.bodyMedium);
+  StacThemeTextStyle get bodyMedium =>
+      const StacThemeTextStyle(textTheme: StacMaterialTextStyle.bodyMedium);

(Apply similarly to all getters.)

---

300-305: Optional: omit nulls in custom style JSON to reduce noise.

If compatibility requires fewer nulls, annotate with includeIfNull: false.

-@JsonSerializable()
+@JsonSerializable(includeIfNull: false)
 class StacCustomTextStyle extends StacTextStyle {

Regenerate and verify downstream snapshots.

Also applies to: 426-429

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro