Separate CMakeLists for each test target #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
approved these changes
Sep 15, 2025
|
The Android build is not happy about this change: https://ci.sfml-dev.org/#/builders/1/builds/2777/steps/11/logs/stdio |
|
Will take a look later but suspect I just need to update the paths it deploys assets to on the device |
|
So really should be using a proper android app for the tests, or failing that use cmake test fixtures to copy test data rather than a build target, but to keep the scope down for this change I've just updated the existing paths so android tests should pass now |
|
Seems our android setup is broken on windows currently which is all I have access to today - Have made an educated guess at the fix |
4b3c110 to
5ec29df
Compare
|
Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor restructure of the cmake structure - Tests already have their own folder for source and resource files, and it's generally good practice (as we do throughout the rest of the project) to also have separate CMakeLists for each subdirectory/target
Generally makes It easier to understand and work with the tests