Backport Fixes for 3.0.2 #3575
Merged
Backport Fixes for 3.0.2 #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SFMLConfig.cmake` uses the `if(... IN_LIST` feature which requires policy `CMP0057` to be enabled (added in CMake 3.3). If an application uses `find_package(SFML)` with a minimum CMake version set to less than `3.3`, the `IN_LIST` lines cause a CMake error. Fix this by setting the minimum CMake policy we require in `SFMLConfig.cmake`. CMake keeps a policy stack so this does not affect the application's policy.
Commit e512771 ("Install pkgconfig only if module is built") attempted to move the pkg-config installation rules into `sfml_add_library`, but this fails if `SFML_PKGCONFIG_INSTALL_DIR` is unset because this code is run before the default value is set in `CMakeLists.txt`. Fix by moving the `add_subdirectory(src/SFML)` line below the pkg-config setup code. Closes: #3504
|
You may also want to backport the following fix: 3651072 I understand though if the fact that it is on the Android build makes it lower priority for a release like this. 👍 |
The llvm 21 release adds a new on by default warning for charN_t implicit conversion. This adds a static cast to get around that.
Adds the necessary warning about macOS 'Accessibility' permission requirements for the setPosition functions, addressing the remaining part of issue #3533.
0e352a1 to
f3bd79a
Compare
|
Good idea, I've included the commit! |
ChrisThrasher
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Despite previous statements of not doing a SFML 3.0.2 release, I feel quite comfortable pushing this one out, given that the release build is fully automated now.
How to test this PR?
CI should pass