Set a constant chunk size #165
Conversation
biggus/__init__.py
Outdated
There was a problem hiding this comment.
It doesn't make sense to me to keep the concept of bytes. Really you're moving from counting bytes to counting array elements.
There was a problem hiding this comment.
In other words, I'd rename this variable as something like n_elements and start with n_elements = 1
|
Replaced Have made necessary test changes and added an admittedly complex integration test that captures a previously-failing edge case that has been fixed by the change to |
|
Hmm, though I still can't get the Travis tests working 😠 All the tests pass locally! |
You tested py3k, right? |
|
Ah! Much better 😀 |
|
Hi @dkillick the tests are passing but there are merge conflicts, please may you rebase and push? thank you |
890c584 to
c240845
Compare
|
Rebased. Bump? @pelson @rhattersley |
Removes cleverness in setting variable (bytes and size-based) chunk sizes in favour of fixing a chunk size of 8 bytes. This works around a problem where performing operations on arrays with differing dtypes causes a broadcasting error because the chunks end up having differing sizes.
Also improves the
_all_slicestests and documentation because these changes flowed from confirming that the right approach was being followed to make this change.Closes #161 and fixes #164.