Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jan 9, 2023

๐Ÿš€ Pull Request

Description

Replaces #5113.

  • Updates lock files with the latest resolvable dependencies.
  • Explicitly sets the y limits of test_2d_coord_bounds_platecarree() to avoid a Cartopy bug.
  • Replaces a use of np.float with float in iris.tests.unit.analysis.maths.
    • Prompted by NumPy v1.24
  • Replaces various uses of np.int.
    • Prompted by NumPy v1.24

Consult Iris pull request check list

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers (and @rcomer) Awesome work ๐Ÿ†

Thanks ๐Ÿ‘

@bjlittle bjlittle merged commit e883799 into SciTools:main Jan 10, 2023
@trexfeathers
Copy link
Contributor Author

Thanks @bjlittle!

trexfeathers added a commit to trexfeathers/iris that referenced this pull request Feb 21, 2023
โ€ฆing conflicts.

* Updated environment lockfiles

* Use set_ylim for test_2d_coord_bounds_platecarree.

* Don't use np.float for maths tests.

* Remove uses of np.int .

Co-authored-by: Lockfile bot <[email protected]>
@trexfeathers trexfeathers deleted the 5113_fixes branch February 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants