Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented May 17, 2023

Here's my suggestion explaining the benefits of delayed saves, and Distributed.

We could consider a new UserGuide section for this, but I think we can still argue that this is a special usage + doesn't belong there.

@pp-mo
Copy link
Member Author

pp-mo commented May 17, 2023

@bjlittle think you suggested this ?

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aea58cc) 89.32% compared to head (9fe4e1b) 89.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.6.x    #5322   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          89       89           
  Lines       22392    22392           
  Branches     5375     5375           
=======================================
  Hits        20002    20002           
  Misses       1640     1640           
  Partials      750      750           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pp-mo
Copy link
Member Author

pp-mo commented May 17, 2023

Thanks @bjlittle
Since the above, discussed offline, so I think we now covered both those comments ?

@bjlittle bjlittle self-requested a review May 18, 2023 11:42
@bjlittle bjlittle self-assigned this May 18, 2023
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pp-mo Awesome, this is much better, with enough detail to sell the feature.

Thanks 💯

@bjlittle bjlittle merged commit 79bc09e into SciTools:v3.6.x May 18, 2023
tkknight added a commit to tkknight/iris that referenced this pull request May 21, 2023
* upstream/main:
  Updated environment lockfiles (SciTools#5332)
  Support netcdf variable emulation (SciTools#5212)
  Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214)
  minor refinement to release do-nothing script (SciTools#5326)
  update bibtex citation for v3.6.0 release (SciTools#5324)
  Whats new updates for v3.6.0 (SciTools#5323)
  Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322)
  Updated environment lockfiles (SciTools#5320)
  Bugfix 4566 (SciTools#4569)
  Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970)
tkknight added a commit to tkknight/iris that referenced this pull request Nov 9, 2023
* upstream/main:
  Updated environment lockfiles (SciTools#5334)
  Iris Docs: Dark theme ready (SciTools#5299)
  Updated environment lockfiles (SciTools#5332)
  Support netcdf variable emulation (SciTools#5212)
  Support netCDF load+save on dataset-like objects as well as filepaths. (SciTools#5214)
  minor refinement to release do-nothing script (SciTools#5326)
  update bibtex citation for v3.6.0 release (SciTools#5324)
  Whats new updates for v3.6.0 (SciTools#5323)
  Added whatsnew notes on netcdf delayed saving and Distributed support. (SciTools#5322)
  Updated environment lockfiles (SciTools#5320)
  Bugfix 4566 (SciTools#4569)
  Simpler/faster data aggregation code in `aggregated_by` (SciTools#4970)
  update release_do_nothing script (SciTools#5311)
  Restore latest Whats New files.
  Updated environment lockfiles (SciTools#5308)
  release_do_nothing script updates from v3.6.0rc0 (SciTools#5306)
  Whats new updates for v3.6.0rc0 (SciTools#5300)
  Bump scitools/workflows from 2023.04.3 to 2023.05.0 (SciTools#5303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🏁 Done - v3.6.0

Development

Successfully merging this pull request may close these issues.

2 participants