[pull] main from facebook:main #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #4476 This previously would drop the pruning_target_parameterization and risk_measure if they were set. Reviewed By: saitcakmak, Balandat, ItsMrLin Differential Revision: D85777593 fbshipit-source-id: 76a9b2147a37de22e7e09df2514a886f9516b193
Summary: Pull Request resolved: #4479 There is a mismatch between the hover tip and the x-axis labels for ArmEffectsPlot (see test plan for comparisons). This is caused by us filtering out NaNs from `trial_df` into `xy_df`, but continuing to use trial_df to create the hover text inside of `_prepare_function`. Issue brought to our attentio by a user [here](https://fb.workplace.com/groups/ae.feedback/posts/25399242543017088/?comment_id=25423933367214672) Reviewed By: andycylmeta Differential Revision: D85797624 fbshipit-source-id: 7ca4df6e3345c510c2b68080d180461b24518384
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )