-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency file
Description
Right now, we have an upper-bound version constraint on Prism here:
Line 27 in 15448ad
| spec.add_dependency("prism", ">= 0.18.0", "< 0.22") |
It looks like the original reason for this was to prevent a breaking change from affecting RBI in 2abfa69. In practice, this works well in the moment, but when applications need to specify a new version of Prism, they can't (because RBI is being strict for seemingly no reason).
This seems to have caused more strain on maintainers of RBI to release a new version for every version bump of a dependency, and that doesn't make sense. Can we relax this dependency to either:
- Remove the upper-bound entirely, and expect maintainers of Prism to fix unintended breaking changes with subsequent releases.
- Restrict to the next major version (1.0), and trust Prism to introduce breaking changes intentionally with a major version bump.
I'm asking because I got bit by this while testing a patch on Packwerk that's attempting to use Prism.
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency file