JS-731 AST consumers can be disabled #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2ec2a7 to
a623b8a
Compare
edc2fe2 to
09a35f7
Compare
vdiez
approved these changes
May 23, 2025
| this.consumers = List.copyOf(consumers); | ||
| LOG.debug("Registered JsAnalysisConsumers {}", this.consumers); | ||
| this.consumers = consumers.stream().filter(JsAnalysisConsumer::isEnabled).toList(); | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
why the need for this check? if log level is higher it will just not be logged, right?
There was a problem hiding this comment.
indeed, it's a not needed optimisation, as computing the value is not expensive here, I will remove it for simplicity.
There was a problem hiding this comment.
that's ok, no need to remove. I just wanted to make sure
There was a problem hiding this comment.
To late 😄
I think it is more readable without,
the code is called once per analsysis,
less is more 👍
I also added some comments on the deprecated properties.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-731